Add php 8.4 support - #18
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The Composer PHP constraint change appears to drop 8.2/8.3 support (and CI no longer tests them), which conflicts with the stated goal of “adding” 8.4 support.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR aims to add PHP 8.4 support by updating the package’s PHP version constraint and aligning CircleCI to run on PHP 8.4.
Changes:
- Updated
composer.jsonto require PHP^8.4. - Updated CircleCI Docker images from
cimg/php:8.2tocimg/php:8.4across build, analysis, and test jobs.
File summaries
| File | Description |
|---|---|
| composer.json | Updates the Composer PHP platform constraint to ^8.4. |
| .circleci/config.yml | Switches all CircleCI jobs to run on the cimg/php:8.4 image. |
Review details
Suppressed comments (2)
.circleci/config.yml:31
- All CI jobs were switched from PHP 8.2 to 8.4, which removes test coverage for PHP 8.2/8.3; if the package is intended to support 8.2+ (as before), consider running the workflow on a PHP-version matrix instead of only 8.4.
docker:
- image: cimg/php:8.4
.circleci/config.yml:60
- All CI jobs were switched from PHP 8.2 to 8.4, which removes test coverage for PHP 8.2/8.3; if the package is intended to support 8.2+ (as before), consider running the workflow on a PHP-version matrix instead of only 8.4.
docker:
- image: cimg/php:8.4
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
10
to
12
| docker: | ||
| - image: cimg/php:8.2 | ||
| - image: cimg/php:8.4 | ||
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
thijskok
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.