Skip to content

search: fix search-entries.xml title construction when outside top le… #1360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MykolaGolubyev merged 1 commit into from
Oct 20, 2025
Merged

search: fix search-entries.xml title construction when outside top le… #1360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions znai-docs/znai/release-notes/1.81/fix-2025-10-19-global-search-entries-comma.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
* Fix: `/search-entries.xml` correctly constructs `title` field when text is outside a top level header
9 changes: 8 additions & 1 deletion znai-website-gen/src/main/java/org/testingisdocumenting/znai/website/WebSite.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -610,8 +610,15 @@ private String searchEntryTitle(TocItem tocItem, PageSearchEntry pageSearchEntry
docMeta.getType() : pageSearchEntry.getPageSectionTitle());
}

return docMeta.getTitle() + ": " + tocItem.getPageTitle() + ", " + pageSearchEntry.getPageSectionTitle() +
String pageSectionPart = pageSearchEntry.getPageSectionTitle().isEmpty() ?
"" :
", " + pageSearchEntry.getPageSectionTitle();

String chapterPart = tocItem.getChapterTitle().isEmpty() ?
"" :
" [" + tocItem.getChapterTitle() + "]";

return docMeta.getTitle() + ": " + tocItem.getPageTitle() + pageSectionPart + chapterPart;
}

// each markup file may refer other files like code snippets or diagrams
Expand Down