Skip to content

Work around nullability annotations mismatches #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brianrourkeboll wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Work around nullability annotations mismatches #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a6d98d
Enable `RespectNullableAnnotationsDefault` & `RespectRequiredConstruc…
brianrourkeboll Oct 6, 2026
bf29ab8
Disable `RespectNullableAnnotationsDefault` & `RespectRequiredConstru…
brianrourkeboll Oct 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,8 @@
<!-- Defines the StrongNamePublicKeys class with constant which contains the repo identity public key formatted for use in InternalsVisibleTo attributes. -->
<Compile Include="$(MSBuildThisFileDirectory)\StrongNamePublicKeys.cs" Visible="false" />
</ItemGroup>
</Project>
<ItemGroup>
<RuntimeHostConfigurationOption Include="System.Text.Json.Serialization.RespectNullableAnnotationsDefault" Value="true" />
<RuntimeHostConfigurationOption Include="System.Text.Json.Serialization.RespectRequiredConstructorParametersDefault" Value="true" />
</ItemGroup>
</Project>
5 changes: 5 additions & 0 deletions src/Docker.DotNet/JsonSerializer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,11 @@ private JsonSerializer()
_options.Converters.Add(new JsonEnumMemberConverter<TaskState>());
_options.Converters.Add(new JsonDateTimeConverter());
_options.Converters.Add(new JsonTimeSpanNanosecondsConverter());
#if NET9_0_OR_GREATER
// https://github.com/testcontainers/Docker.DotNet/issues/129
_options.RespectNullableAnnotations = false;
_options.RespectRequiredConstructorParameters = false;
#endif
_options.MakeReadOnly();
}

Expand Down