terminal: preserve modified physical Enter keys - #5256
Open
tianrking wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5198
KeyHandlercurrently emits the same carriage return for physical Enter, Shift+Enter, and Ctrl+Enter. This prevents terminal applications from using a modified Enter as an insertion/newline action.This change keeps the existing plain Enter (
CR) and Alt+Enter (ESC CR) behavior, while mapping physical Shift+Enter and Ctrl+Enter toLF. The modifier check is intentionally limited to the existing key path and does not enable a new keyboard protocol unconditionally.Validation:
KeyHandlerTestcompiled against Android API 36 with JUnit 4.13.2 and ran successfully (OK (2 tests)).git diff --check