fix(copyable): round the copy button's corners - #3954
Open
bilal-karim wants to merge 1 commit into
Open
bilal-karim wants to merge 1 commit into
bilal-karim wants to merge 1 commit into
Conversation
The copy button's hover, press, and focus backgrounds rendered as a hard square because the button had no border radius. Match Holocene's Button, which uses `rounded`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
bilal-karim
marked this pull request as ready for review
September 25, 2026 15:17
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rounds the copy button so its hover, press, and focus states no longer render as a hard square.
holocene/copyable/button.sveltesetshover:bg-interactive-tertiary-hover,active:bg-interactive-tertiary-press, andfocus-visible:bg-interactive-secondary, but had no border radius, so every copy button in the app showed a square background on interaction.rounded, matching Holocene'sButton, which uses the same radius.Copyabledoesn't forward a class to its inner copy button, so consumers can't fix this locally without targeting the component's markup.🤖 Generated with Claude Code