Migrate advanced_visibility_test.go#10447
Open
stephanos wants to merge 3 commits into
Open
Conversation
stephanos
force-pushed
the
stephanos/migrate-advanced_visibility_test
branch
3 times, most recently
from
2bc5e07 to
2d95a63
Compare
stephanos
commented
Jun 10, 2026
| var err error | ||
| s.Require().NoError(err) | ||
|
|
||
| s.sysSDKClient, err = sdkclient.Dial(sdkclient.Options{ |
stephanos
force-pushed
the
stephanos/migrate-advanced_visibility_test
branch
2 times, most recently
from
6632314 to
7bb3d5a
Compare
stephanos
commented
Jun 11, 2026
| s.Equal([]string{}, buildIDs) | ||
|
|
||
| // We should have 3 runs with the v1.1 search attribute: First and second run in chain, and single child | ||
| s.Eventually(func() bool { |
Contributor
Author
There was a problem hiding this comment.
Lots are already converted; converting the stragglers too
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
stephanos
force-pushed
the
stephanos/migrate-advanced_visibility_test
branch
from
7bb3d5a to
e29f9a7
Compare
stephanos
force-pushed
the
stephanos/migrate-advanced_visibility_test
branch
from
c80a2c4 to
e29f9a7
Compare
long-nt-tran
approved these changes
Jun 15, 2026
| esClient, err := esclient.NewFunctionalTestsClient(esConfig, s.Logger) | ||
| s.Require().NoError(err) | ||
| esClient, err := esclient.NewFunctionalTestsClient(esConfig, env.Logger) | ||
| s.NoError(err) | ||
|
|
||
| acknowledged, err := esClient.IndexPutSettings( | ||
| context.Background(), |
Contributor
There was a problem hiding this comment.
Suggested change
| context.Background(), | |
| s.Context(), |
| await.Requiref(s.Context(), s.T(), | ||
| func(t *await.T) { | ||
| s.Awaitf( | ||
| func(s *AdvancedVisibilitySuite) { | ||
| settings, err := esClient.IndexGetSettings(context.Background(), esConfig.GetVisibilityIndex()) |
Contributor
There was a problem hiding this comment.
Suggested change
| settings, err := esClient.IndexGetSettings(context.Background(), esConfig.GetVisibilityIndex()) | |
| settings, err := esClient.IndexGetSettings(s.Context(), esConfig.GetVisibilityIndex()) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WISOTT