Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📖 Docs PR preview links
|
…nested agent checks
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates the TypeScript OpenAI Agents SDK integration page for temporalio/ai-integrations#270, which removes the integration's
agentAsTooland makes the OpenAI Agents SDK's ownagent.asTool()work in Workflows.agent.asTool(). The page dropsagentAsTool, its options table and theNestedAgentInterruptionerror.context,runConfig.modelfor agents that set no model,runConfig.modelSettings, and the runner's model Activity options. They also say that a nested approval pauses the parent run and that a nested run's failure goes back to the model as the tool's output.runConfig.modelapplies to agents that set no model of their own, as in the SDK;agent.on(...)lifecycle hooks are supported;asTool()tools must be created in Workflow code, and the nested setups the runner rejects are listed, with the matching error types.Notes to reviewers
Draft until temporalio/ai-integrations#270 is merged and released. When it is, this page can name the release.
Checked on a build of temporalio/ai-integrations#270, on a local dev server with a scripted model:
instructionsfunction and its inline tool got the run'scontext.An error occurred while running the tool. Please try again. Error: ActivityFailure: Activity task failed, and the run completed.result.interruptions. Approving it and resuming finished the run.runConfig.modelrule, hooks, the rejected nested setups and the summary agent are covered by Breaking: run TypeScript OpenAI Agents as written: agent.asTool() works, runConfig.model no longer overrides an agent's own model, agentAsTool is deprecated ai-integrations#270's Worker tests.That
runConfig.sandboxis passed on to nested runs comes from the OpenAI Agents SDK's code. It wasn't run here.The agent patterns sample moves to
agent.asTool()in temporalio/samples-typescript#534.Vale didn't run locally. The page isn't Prettier-clean on
main, so only the changed paragraphs are rewrapped.