Repository navigation
Breaking: refuse a tool meta resolver on the OpenAI Agents MCP factory's server and send _meta from the TypeScript MCP handles #210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
campoy
merged 20 commits into
main
from
fix/openai-agents-typescript-mcp-tool-meta-dropped
Nov 3, 2026
+454
−39
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
28e58ac
fix(openai-agents): send MCP tool call _meta from the plugin's MCP se…
campoy e94b114
Address review findings
campoy 5d55b69
Address review findings
campoy 5894e85
Address review: stateful serverName, quieter warning, mixed fleets
campoy e8a3cef
Share the MCP handle options in one interface
campoy ed77bd8
Refuse a toolMetaResolver on the factory's server
campoy c69bccb
Address review findings
campoy bfc90d6
Address review findings
campoy c501190
Merge remote-tracking branch 'origin/main' into fix/openai-agents-typ…
campoy 602f1d1
Refuse a stateful factory resolver in the operation Activities, as #2…
campoy aa51e5f
Export TOOL_META_RESOLVER_UNSUPPORTED_TYPE
campoy 62599e6
README: upgrade order for a factory resolver, and the stateful handle…
campoy 0af5470
Merge remote-tracking branch 'origin/main' into fix/openai-agents-typ…
campoy e100cfa
Address the third review: migration replay, export lists, History note
campoy 8df1398
Merge remote-tracking branch 'origin/main' into fix/openai-agents-typ…
campoy 6161ecf
Refuse a tool_meta_resolver on the Python factory's server too
campoy b2f2d76
Point each Python route's resolver refusal at a remedy it can reach
campoy ca75958
README: resolver after a RunState resume, and which Workers to upgrade
campoy 0a36fee
README: the deprecated routes' resolver gets the suffixed server name
campoy 2377901
Merge remote-tracking branch 'origin/main' into fix/openai-agents-typ…
campoy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P3 (tests): nothing committed exercises the path every refusal now points to: no test passes
tool_meta_resolvertotemporal_mcp_server()or checks themetathe factory's server receives.grep -rn tool_meta_resolver tests/finds only the two refusal tests, andInProcessMCPServer.call_tool(lines 125-132) forwardsmetawith no assertion on it, so the body's 'already worked' rests on no test. A probe passes at this head: a subclass ofInProcessMCPServerthat appendsmetaincall_tool, a Workflow withtemporal_mcp_server('hello', tool_meta_resolver=resolver)whereresolverreturns{'tenant': 't-7', 'tool': ctx.tool_name, 'server': ctx.server_name}, a model making onesay_hellocall, andassert metas == [{'tenant': 't-7', 'tool': 'say_hello', 'server': 'hello'}]. Non-blocking.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added
test_temporal_mcp_server_sends_tool_metain b2f2d76. ARecordingServerrecords themetathe factory's server gets, the Workflow passestemporal_mcp_server("hello", tool_meta_resolver=...), and the test asserts{"tenant": "t-7", "tool": "say_hello", "server": "hello"}for both calls.