fix: soilweb links#340
Open
jjmaynard wants to merge 8 commits into
Open
Conversation
garobrik
force-pushed
the
fix/soilweb-links
branch
from
573a6c0 to
80cb2d2
Compare
…soil identification - Replace index-based URL storage with component key mapping to fix URL mismatches - Add deterministic sorting to groupby operations for consistent component ordering - Improve component name duplication handling with sorted processing - Fix Series URL generation logic to properly match components with their URLs Resolves issues where soil components received incorrect SDE/SEE URLs due to sorting misalignment between URL lists and component data ordering.
Improves code readability by reformatting long sort_values and other function calls across the file. No functional changes were made; only code style and formatting were updated for clarity and consistency.
garobrik
force-pushed
the
fix/soilweb-links
branch
from
80cb2d2 to
099c465
Compare
garobrik
reviewed
Mar 4, 2026
garobrik
left a comment
garobrik
left a comment
Member
There was a problem hiding this comment.
hey jon, i'm seeing the expected URL fix, but i'm surprised to also see that the data scores have changed by up to 10%, is that an expected outcome for this PR as well?
- Update US snapshot fixtures to reflect current deterministic outputs captured from fixture-backed test execution. - Keep snapshot set aligned with branch baseline before subsequent logic changes. - No production code changes in this commit; snapshot JSON artifacts only.
- Replace positional OSD/ESD alignment paths with normalized cokey-keyed mapping to avoid component drift when grouped data orders differ. - Harden texture infill behavior by supporting partial-missing horizons and filling only missing layer values from OSD while preserving available SSURGO values. - Update getTexture classification handling: return None for missing/NaN sand-clay inputs, refresh classification doc details, and adjust condition/choice evaluation for safer mapping. - Normalize texture modifiers (e.g. very fine/fine/medium/coarse) before getSand/getClay lookups so OSD labels map consistently to canonical texture classes. - Fix information_gain weighted entropy computation by using aligned numeric Series reduction and normalizing target_col handling to prevent int/str aggregation TypeError in soil_sim. - Regenerate point validation artifact for 32.25459,-106.76431 and update related test/output files produced by the branch workflow.
jjmaynard
force-pushed
the
fix/soilweb-links
branch
2 times, most recently
from
fdbb709 to
7936deb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves URL mapping issues in the US soil identification system where soil components were receiving incorrect SDE/SEE URLs due to index misalignment caused by component reordering during processing. #294
Problem
Solution
URL Mapping Overhaul:
Deterministic Ordering: