Skip to content

CI table improvements #5129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ptomato wants to merge 3 commits into
base: main
Choose a base branch
from
+5 −3
Open

CI table improvements #5129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
609aab8
Use minus emoji in table instead of big red X
ptomato Sep 2, 2026
d57e39d
Drop unneeded information from engine test result artifacts
ptomato Sep 3, 2026
b8d188c
TEMP COMMIT: Make this test run
ptomato Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/engine-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,8 @@ jobs:
--hostArgs="${{ matrix.engine.hostArgs }}" \
--reporter json \
-- ${{ needs.changed-tests.outputs.all_changed_files }} \
> "results-${{ matrix.engine.key }}.json"
| jq 'map({relative, scenario, result})' \
| tee "results-${{ matrix.engine.key }}.json"

@gibson042 gibson042 Sep 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do better than JSON in this log output, e.g.

Suggested change
| tee "results-${{ matrix.engine.key }}.json"
| tee "results-${{ matrix.engine.key }}.json"
| jq -r '
map(
"\n\(if .result.pass then "PASS" else "FAIL" end) \(.relative) [\(.scenario)]\(if .result.pass then "" else "\n\(.result.message)" end)"
)
| .[]
'

to produce text like

PASS path/to/foo [default]

FAIL path/to/bar [default]
failure message


- name: Upload results
if: always()
Expand Down
1 change: 1 addition & 0 deletions test/intl402/Locale/prototype/getWeekInfo/firstDay-by-id.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ info: |
features: [Reflect,Intl.Locale,Intl.Locale-info]
---*/


@gibson042 gibson042 Sep 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why add this line?

@ptomato ptomato Sep 3, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just temporary, in order to get a test to run.

const validFirstDayOfWeekIds = [
["en-u-fw-mon", 1],
["en-u-fw-tue", 2],
Expand Down
4 changes: 2 additions & 2 deletions tools/misc/build-results-comment.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,8 @@ function combineMessages(sloppyMessage, strictMessage) {
}

function formatFail(message) {
if (!message) return '❌';
return `[❌](## "${sanitizeTableMarkdown(message)}")`;
if (!message) return '➖';

@gibson042 gibson042 Sep 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also like the emoji to be part of an obvious pair—(👍, 👎), (🙆, 🙅), (✅, ❎), etc.

return `[➖](## "${sanitizeTableMarkdown(message)}")`;
}

// https://spec.commonmark.org/0.31.2/#links
Expand Down