Tests for Thenable-curtailment - #5123
Open
mgaudet wants to merge 3 commits into
Open
Conversation
These tests were authored with the assistance of an LLM, however they were targeted and reviewed by myself. The tests were validated on the prototype implemetnation of SafePromiseResolve in the Firefox tree; the tests highlight a current divergence between the SpiderMonkey implementation and the spec-text as written (specifically SpiderMonkey will currently defer on a `then` setter even with no getter, which is not correct by specification).
mgaudet
force-pushed
the
thenable-curtailment-testing
branch
from
September 1, 2026 16:58
c3386c6 to
99c60be
Compare
|
32 new or modified tests were run on 7 engines. Test results
|
Author
|
(See #5122 for the testing plan) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just want to call out the commit message on c3386c6, esp. in light of #5115
(Of course, seeing that in the Github editor I realize how badly I typo'd some of that message 🤦 )