speed up linting - #5121
Merged
Merged
Conversation
gibson042
approved these changes
Aug 30, 2026
gibson042
left a comment
gibson042
left a comment
Member
There was a problem hiding this comment.
LGTM, and (referring to the prompt) I'm happy to continue maintaining the result.
ptomato
approved these changes
Aug 31, 2026
ptomato
left a comment
ptomato
left a comment
Member
There was a problem hiding this comment.
Nice, thanks for looking into this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was generated by Claude in response to
On my machine this takes it from ~90 seconds to ~5 seconds. Half of that is from caching the checks instead of reconstructing them per file; the remainder is from using pyyaml's c parser instead of the python one. Also bumps the version of pyyaml so that it is more likely to have the c parser included in CI; the only breaking change is dropping support for Python 2.7, which seems fine.
I am reasonably sure the change to get the events by running the parser twice is semantics-preserving, and it's actually faster on my machine than the current subclassing approach even when using pyyaml's python-based parser.