Skip to content

Fix duplicate include directive in TypedArray set test - #5119

Merged
gibson042 merged 2 commits into
tc39:mainfrom
masnagam:fix/typedarray-set-duplicate-include
Aug 29, 2026
Merged

Fix duplicate include directive in TypedArray set test#5119
gibson042 merged 2 commits into
tc39:mainfrom
masnagam:fix/typedarray-set-duplicate-include

Conversation

@masnagam

Copy link
Copy Markdown
Contributor

Remove duplicate 'testTypedArray.js' from the includes list in src-typedarray-not-big-throws.js.

The includes directive had the same file listed twice, which is unnecessary.

Remove duplicate 'testTypedArray.js' from includes list in src-typedarray-not-big-throws.js
@masnagam
masnagam requested a review from a team as a code owner August 29, 2026 05:17
Remove duplicate 'testTypedArray.js' from includes list in:
- test/built-ins/TypedArray/prototype/set/src-typedarray-big-throws.js
- test/built-ins/TypedArrayConstructors/ctors-bigint/typedarray-arg/src-typedarray-not-big-throws.js
- test/built-ins/TypedArrayConstructors/ctors/typedarray-arg/src-typedarray-big-throws.js

These files had the same include file listed twice, which is unnecessary.
@masnagam

Copy link
Copy Markdown
Contributor Author

During testing with the bee-browser/bee JavaScript runtime, duplicate includes were detected in this file and three related files. The same pattern of duplicate 'testTypedArray.js' entries was found in:

  • test/built-ins/TypedArray/prototype/set/src-typedarray-big-throws.js
  • test/built-ins/TypedArrayConstructors/ctors-bigint/typedarray-arg/src-typedarray-not-big-throws.js
  • test/built-ins/TypedArrayConstructors/ctors/typedarray-arg/src-typedarray-big-throws.js

Additional commits have been added to this PR to fix all four files together.

@gibson042
gibson042 enabled auto-merge (squash) August 29, 2026 17:13
@github-actions

Copy link
Copy Markdown

4 new or modified tests were run on 7 engines.

View workflow run

Test Engine262 GraalJS JavaScriptCore QuickJS SpiderMonkey V8 XS
built-ins/TypedArray/prototype/set/BigInt/src-typedarray-not-big-throws.js
built-ins/TypedArray/prototype/set/src-typedarray-big-throws.js
built-ins/TypedArrayConstructors/ctors-bigint/typedarray-arg/src-typedarray-not-big-throws.js
built-ins/TypedArrayConstructors/ctors/typedarray-arg/src-typedarray-big-throws.js

@gibson042
gibson042 merged commit 14e8c90 into tc39:main Aug 29, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants