-
Notifications
You must be signed in to change notification settings - Fork 562
Test the format of a German date with a short weekday and no year #3739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MidnightDesign
wants to merge
8
commits into
tc39:main
Choose a base branch
from
MidnightDesign:german-weekday-no-year
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+11
−0
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
8ef0505
Test the format of a German date with a short weekday and no year
MidnightDesign 977de73
Add a copyright and a description
MidnightDesign 87c359f
Months are zero-based
MidnightDesign 7734e48
Add an esid to the new test
MidnightDesign 4192b3d
Add a locale tag to the new test
MidnightDesign 2c9cc99
Merge branch 'main' into german-weekday-no-year
MidnightDesign 5988a2c
Merge branch 'main' into german-weekday-no-year
MidnightDesign e2a8581
Change assertion to only check for weekday with comma, not the whole …
MidnightDesign File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
11 changes: 11 additions & 0 deletions
11
test/intl402/DateTimeFormat/prototype/format/german-weekday-no-year.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| // Copyright (C) 2022 Rudolph Gottesheim. All rights reserved. | ||
| // This code is governed by the BSD license found in the LICENSE file. | ||
| /*--- | ||
| esid: sec-formatdatetime | ||
| description: > | ||
| Short German weekdays should be followed by a comma. | ||
| locale: [de] | ||
| ---*/ | ||
|
MidnightDesign marked this conversation as resolved.
|
||
|
|
||
| let dtf = new Intl.DateTimeFormat("de", { weekday: "short", day: "numeric", month: "long"}); | ||
| assert.sameValue(dtf.format(new Date(2022, 11, 24)).includes("Sa.,"), true, "German weekday without year"); | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.