Conversation
; add different Redis versions to test matrix - Add performance improvements available to Redis 8.10+ users (replace expensive `read_streams` Lua script with a single XREADGROUP call) - Run tests across various Redis versions - Switch to zuban for type checking, use both default and mypy modes - Remove `streaq.utils.gather` - Update ruff to v0.16.0 and adopt new default lint rules - Refactor Lua to avoid atomic updates of multiple streams which can cause unpredictability together with XREADGROUP COUNT - Remove `Worker.__slots__` Pending: zuban bug fix (zubanls/zuban#524), new coredis release Nice to have: anyio gather impl (agronholm/anyio#1173)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
expensive
read_streamsLua script with a single XREADGROUP call with CLAIM and MAXCOUNT args.)cause unpredictability together with XREADGROUP COUNT
streaq.utils.gather(in anyio >= 4.15.0)Worker.__slots__Pending: zuban release, coredis release
Pre-merge checklist
make lint)make test)