Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TaskDepends()andWorkerDepends()are gone. Usemy_task.context/my_middleware.context/worker.contextinstead.health_crontabparameter fromWorker, doesn't do anything since health check was refactored.serializeranddeserializerparameters toWorkernow accept both sync and async callables. This can be used to send expensive calls to threads when not using the GIL or when using functions that release the GIL (see Sync serializer/deserializer calls block the async event loop #145). All internal callers updated toawaitthem.TaskStatusnow inherits fromStrEnum(wasstr, Enum).coredisto>=6.7.0; addpytest-randomlydev dependency.Reworks the producer/consumer loop and task execution path to cut per-task overhead, plus consolidates task-publishing logic that was duplicated across three call sites.
_countcounter.send_nowaitinstead of being collected into an intermediate list.XREADGROUPwithBLOCKto block for much longer periods of time.run_taskpipeline switched fromtransaction=Truewith an eager gather totransaction=Falsewith lazy awaits, so reads resolve only when needed.fnclosure replaced with a cachedrunnerproperty on registered tasks — sync tasks getasyncifyapplied once instead of on every run._async_serializer/_async_deserializerflags at init rather than callinginspect.isawaitableper (de)serialization.Task._enqueue,Task._chain, andenqueue_manyinto a singleWorker.publish_taskhelper._recursepass over a single transaction pipeline.Related issue(s)
Fixes #145
Pre-merge checklist
make lint)make test)