feat(tests): Add unit-serial to test TASKGRAPH_SERIAL#958
Conversation
0626c38 to
3d7cca6
Compare
bhearsum
left a comment
There was a problem hiding this comment.
It looks like there's a test failure with TASKGRAPH_SERIAL currently? 😬. All the more reason to run these...
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #958 +/- ##
==========================================
+ Coverage 77.72% 77.99% +0.26%
==========================================
Files 130 130
Lines 12137 12140 +3
Branches 1477 1477
==========================================
+ Hits 9434 9469 +35
+ Misses 2315 2282 -33
- Partials 388 389 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3d7cca6 to
260f843
Compare
260f843 to
80eb1fb
Compare
|
Updated PR title + commit message to reflect changes |
bhearsum
left a comment
There was a problem hiding this comment.
Approving, but please consider applying the suggestions.
| not os.environ.get("TASKGRAPH_USE_THREADS"), | ||
| reason="requires multithreading to be enabled", | ||
| ) | ||
| asynconly = pytest.mark.skipif( |
There was a problem hiding this comment.
| asynconly = pytest.mark.skipif( | |
| multiprocessonly = pytest.mark.skipif( |
(async and multiprocess are not the same thing.)
| reason="requires multithreading to be enabled", | ||
| ) | ||
| asynconly = pytest.mark.skipif( | ||
| os.environ.get("TASKGRAPH_SERIAL"), reason="requires TASKGRAPH_SERIAL to be 0" |
There was a problem hiding this comment.
| os.environ.get("TASKGRAPH_SERIAL"), reason="requires TASKGRAPH_SERIAL to be 0" | |
| os.environ.get("TASKGRAPH_SERIAL"), reason="requires multiprocessing to be enabled" |
(This is checking whether or not TASKGRAPH_SERIAL is not at all, not looking for whether or not it is 0.)
|
|
||
|
|
||
| @threadsonly | ||
| @asynconly |
There was a problem hiding this comment.
I think it would be better to fix the threadsonly marker to account for TASKGRAPH_SERIAL rather than stack these in this case, but this works too.
No description provided.