refactor(mvp): harden runtime and streaming flow - #9
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Note
Medium Risk
Touches core request/streaming flow, runtime lifecycle, and LLM adapter error handling; regressions could break PRD runs or SSE replay despite added test coverage.
Overview
Refactors the backend into a lifespan-managed runtime with centralized
AppSettings, structured logging, and explicit state-backend selection (redis/memory/autofallback) plus a new/readyendpoint that reflects store health.Hardens generation/streaming by persisting richer
PRDState(addsidea+ terminalerror), broadcasting via a shared fan-outStreamerService, and making/api/v1/stream/{run_id}replay the latest persisted state before streaming subsequent revisions (including terminal completion/error states).Updates vanilla LLM adapters to use typed
AdapterError, configurable models/timeouts, thegoogle-genaiSDK, and structured success/failure logging; pipeline execution now records truthful step transitions and persists terminal errors without faking successful content. Frontend/docs/env/Docker packaging are narrowed to shipped PRD-only behavior, and extensive unit/integration tests are added for runtime selection, SSE replay, pipeline transitions, CLI wiring, and frontend helpers.Written by Cursor Bugbot for commit bb46c14. This will update automatically on new commits. Configure here.