fix(core): Resolve networking, environment, and async blocking issues - #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses several fundamental issues that were preventing the application from running successfully in the Dockerized environment. The core problems were related to inter-container networking, environment variable loading, and a critical bug where the Google GenAI SDK was blocking the asynchronous event loop.
Key Changes
BACKEND_URLenvironment variable, fixing the "Connection Refused" error.python-dotenvto ensure that API keys and other configuration from the.envfile are properly loaded at startup.vanilla_googleadapter, which was causing the entire application to hang, has been patched. It now runs the blocking SDK calls in a separate thread using aThreadPoolExecutor, ensuring the server remains responsive.docker-compose.ymlhas been remapped from port6379to6380to avoid common port conflicts during local development.These changes collectively restore the application to a functional state and improve its stability and reliability for local development.