Skip to content

device: add options for queue configuration - #84

Merged
jwhited merged 1 commit into
tailscalefrom
jwhited/device-opts
Aug 13, 2026
Merged

device: add options for queue configuration#84
jwhited merged 1 commit into
tailscalefrom
jwhited/device-opts

Conversation

@jwhited

@jwhited jwhited commented Aug 13, 2026

Copy link
Copy Markdown
Member

Replace the mutable iOS queue and pool global vars with per-device functional options. Keep platform-specific defaults as exported Default constants, and preserve existing NewDevice callers through a variadic options parameter.

Updates tailscale/corp#22467
Updates tailscale/corp#46396
Updates tailscale/corp#37878

@jwhited
jwhited requested a review from a team August 13, 2026 19:31

@sfllaw sfllaw left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a very minor nitpick.

Comment thread device/device.go Outdated
Comment thread device/device.go Outdated
Replace the mutable iOS queue and pool global vars with per-device
functional options. Keep platform-specific defaults as exported Default
constants, and preserve existing NewDevice callers through a variadic
options parameter.

Updates tailscale/corp#22467
Updates tailscale/corp#46396
Updates tailscale/corp#37878

Signed-off-by: Jordan Whited <jordan@tailscale.com>
@jwhited
jwhited force-pushed the jwhited/device-opts branch from 1ce3443 to cdfcacc Compare August 13, 2026 21:11
@jwhited
jwhited merged commit aa425f1 into tailscale Aug 13, 2026
15 checks passed
@jwhited
jwhited deleted the jwhited/device-opts branch August 13, 2026 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants