Skip to content

fix(cli): validate target fps #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
taigrr wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(cli): validate target fps #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions cmd/trophy/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ var (
bgColor string
)

const minTargetFPS = 1

func main() {
cmd := &cobra.Command{
Use: "trophy <model.obj|model.glb|model.stl>",
Expand Down Expand Up @@ -407,7 +409,18 @@ func parseBackgroundColor(input string) (color.RGBA, error) {
return color.RGBA{R: channels[0], G: channels[1], B: channels[2], A: 255}, nil
}

func validateTargetFPS(fps int) error {
if fps < minTargetFPS {
return fmt.Errorf("invalid fps %d: must be at least %d", fps, minTargetFPS)
}
return nil
}

func run(modelPath string) (err error) {
if err := validateTargetFPS(targetFPS); err != nil {
return err
}

bg, err := parseBackgroundColor(bgColor)
if err != nil {
return err
Expand Down
16 changes: 16 additions & 0 deletions cmd/trophy/main_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,22 @@ func TestParseBackgroundColorInvalid(t *testing.T) {
}
}

func TestValidateTargetFPS(t *testing.T) {
for _, testCase := range []int{1, 30, 60, 120} {
if err := validateTargetFPS(testCase); err != nil {
t.Fatalf("validateTargetFPS(%d) returned error: %v", testCase, err)
}
}
}

func TestValidateTargetFPSInvalid(t *testing.T) {
for _, testCase := range []int{0, -1, -60} {
if err := validateTargetFPS(testCase); err == nil {
t.Fatalf("expected error for fps %d", testCase)
}
}
}

func TestRunInfoUnsupportedFormat(t *testing.T) {
err := runInfo("test.xyz")
if err == nil {
Expand Down