fix(errors): implement filterErr with common adb stderr patterns - #3
Merged
Conversation
- Implement filterErr to detect device-not-found, offline, unauthorized, connection-refused, and multiple-device errors from stderr output - Add ErrDeviceNotFound, ErrDeviceOffline, ErrDeviceUnauthorized, ErrConnectionRefused, ErrMoreThanOneDevice sentinel errors - Remove log.Printf in CaptureSequence (was marked TODO for removal) - Fix ConnString to use local variable instead of mutating value receiver - Update go directive to 1.26.2 - Update README: check implemented features, fix intro typo, add root/keyevent/getevent to supported functions list - Expand filterErr tests for all new error patterns
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
filterErr— previously a stub TODO. Now detects common adb stderr patterns and returns typed sentinel errors:ErrDeviceNotFound— device not foundErrDeviceOffline— device offlineErrDeviceUnauthorized— device unauthorized (USB debugging not approved)ErrConnectionRefused— daemon connection refusedErrMoreThanOneDevice— multiple devices without serial specifiedlog.PrintfinCaptureSequence(was marked TODO for removal)ConnString— use local variable instead of mutating value receiver fieldfilterErrerror patternsAll tests pass with
-race,staticcheckclean.