Add check for invalid types in set var action during trace creation - #85
Merged
Conversation
|
CLANG-FORMAT TEST - PASSED |
kpgriesser
approved these changes
Jun 4, 2026
donofrio
reviewed
Jun 4, 2026
| catch ( const std::exception& e ) { | ||
| printf("Invalid set var: %s\n", valStr_.c_str()); | ||
| printf("Invalid set var action: %s\n", valStr_.c_str()); | ||
| return; |
Collaborator
Author
There was a problem hiding this comment.
IIRC, Scott prefers we use the sst output or printf in "non-debug-console" code. I'm kind of afraid to look at watchpoint, interactive, etc. because I think it's probably a mixed bag.
There was a problem hiding this comment.
sounds like a can of worms best left sealed :)
donofrio
approved these changes
Jun 4, 2026
donofrio
left a comment
donofrio
left a comment
There was a problem hiding this comment.
Looks good! definitely adds some additional robustness
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: When creating a trace with a set action there was no error checking so any errors would not be caught until the trace action was triggered during execution.
This adds checking at trace creation to print an error and abort trace creation if there is a type mismatch for the set action.