Skip to content

T1ERC7683.sol: check if inner message length is 0, early return #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evchip merged 1 commit into from
Dec 15, 2025
Merged

T1ERC7683.sol: check if inner message length is 0, early return #217

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions contracts/src/7683/T1ERC7683.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -698,6 +698,10 @@ contract T1ERC7683 is IT1ERC7683, T1Permit2, AccessControlUpgradeable, EIP712 {

// Remove the first 32 bytes prefix of the message
bytes memory _innerMessage = abi.decode(result, (bytes));

// If inner message is empty, the order was never filled - valid for refund
if (_innerMessage.length == 0) return;

(bool filled,,) = abi.decode(_innerMessage, (bool, bytes32[], bytes[]));

// Revert if the order is already settled
Expand Down