App Center: show app descriptions for not-installed apps#748
Closed
cyberb wants to merge 2 commits into
Closed
Conversation
The redesign added an app description block to the app page, but apps opened from the App Center (not installed) show no description while installed apps do. Add a Playwright assertion on the not-installed File browser page and a data-testid on the description element to reproduce the gap before fixing it.
snapd /v2/find returns an empty description for store apps, so apps opened from the App Center (not yet installed) showed no description while installed apps (sourced from /v2/snaps) did. Enrich store apps with descriptions from apps.syncloud.org/releases/<channel>/index-v2, keyed by app id, when snapd returns an empty one. Applied in both StoreUserApps (App Center list) and FindInStore (app page). Catalog fetch failures degrade gracefully to the previous empty-description behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The platform UI redesign (#747) added an app description block to the app page. It shows for installed apps but is blank for apps opened from the App Center (not yet installed).
Root cause
Find()uses snapd/v2/snaps(local snap metadata), which carriesdescription→ shown.Find()returnsFindInStore()from snapd/v2/find, which returneddescription: ""→showDescriptionhides it.The empty description originates in the store, which dropped the
snap.yamldescription from its find/info responses. Fixed there in syncloud/store#6; once that store change is deployed, snapd relays the description and the platform's existingDescription: s.Descriptionmapping shows it — no platform code change needed.Contents
data-testidon the description element.This test stays red until syncloud/store#6 is merged and deployed to the store.