Skip to content

[Map] Render each UX icon once instead of once per marker #3779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kocal wants to merge 1 commit into
base: 3.x
Choose a base branch
from
+8 −1
Open

[Map] Render each UX icon once instead of once per marker #3779

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/Map/src/Icon/UxIconRenderer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,11 @@
*/
class UxIconRenderer
{
/**
* @var array<string, string>
*/
private array $rendered = [];

public function __construct(
private readonly ?IconRendererInterface $renderer,
) {
Expand All @@ -34,7 +39,9 @@ public function render(string $name, array $attributes = []): string
throw new \LogicException('You cannot use an UX Icon as the "UX Icons" package is not installed. Try running "composer require symfony/ux-icons" to install it.');
}

return $this->renderer->renderIcon($name, [
// Markers of a map overwhelmingly share the same icon, so the same SVG
// was rebuilt once per marker.
return $this->rendered[$name.'|'.serialize($attributes)] ??= $this->renderer->renderIcon($name, [
'xmlns' => 'http://www.w3.org/2000/svg',
...$attributes,
]);
Expand Down
Loading