[Toolkit][Shadcn] Align select with shadcn reference - #3744
Open
laurentdav wants to merge 2 commits into
Open
Conversation
This was referenced Jul 30, 2026
laurentdav
marked this pull request as ready for review
August 4, 2026 20:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #3743.
The existing Shadcn
selectrecipe renders a native HTML control, while the upstream Select is a custom composite component triggered by a button. This aligns the recipe with the current upstream component and leaves native browser behavior to the newnative-selectrecipe.The updated recipe adds the composed
Select:Trigger,Select:Value,Select:Content,Select:Group,Select:Label,Select:Item, andSelect:SeparatorAPI. It supports form submission, required validation, disabled states, keyboard navigation, typeahead, item-aligned and popper positioning, scroll controls, and RTL layouts. Trigger composition follows the ToolkitasChildattributes convention.All current upstream examples are included in the recipe README and covered by regenerated snapshots. Existing native-select usages in the Field, Input, and Pagination examples now use
NativeSelect.This draft is stacked on #3743 so its CI can render those migrated examples. Once #3743 is merged, this PR will contain only the
selectrecipe alignment and its dependent example updates.No companion site change is required: the current site auto-registers Toolkit controllers and scans the installed Shadcn kit during its Tailwind build.
Tests:
bin/ux-toolkit-kit-lint --fail-on-warning kits/shadcnpnpm exec oxfmt --checkon the changed sourcespnpm exec oxlint src/Toolkit/kits/shadcn/select/assets/controllers/select_controller.jsphp -d memory_limit=-1 vendor/bin/phpunit(1089 tests, 2634 assertions)