JFM paper#84
Conversation
- Recovered files are all from previously pushed commit.
…ral time improvements to hydro folder
…' into timing-improvements
…imiting cases - More investigation into low m0 matching MEEM against the package, mismatch is not explained
- cleared top-level of convergence study to helper function scripts - notebook cleanups in e-region-convergence, region-count-convergence, and neighbor-convergence-effects - N_k array previously not updating with m0 changes, now it does (in both multi_condensed and helpers.py)
…n to jfm-paper branch
…g spacing issues around equations
Removed pull_request branch specification from CI workflow
Fix forcing-term callback signature mismatch after I_mk caching refactor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #84 +/- ##
===================================================
+ Coverage 98.38710% 98.38833% +0.00123%
===================================================
Files 11 11
Lines 1302 1303 +1
===================================================
+ Hits 1281 1282 +1
Misses 21 21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rebeccamccabe
left a comment
rebeccamccabe
left a comment
There was a problem hiding this comment.
this is a high-level review focusing on updates to repo structure only, I did not read in depth into any code changes or review details of notebooks. I stopped commenting on the pkl files eventually but comments apply to all pkls.
| [submodule "src/sea-lab-utils"] | ||
| path = src/sea-lab-utils | ||
| url = https://github.com/symbiotic-engineering/sea-lab-utils.git | ||
| [submodule "sea-lab-utils"] |
There was a problem hiding this comment.
duplication not ideal but ok for now
There was a problem hiding this comment.
this was a calkit environment change I think, I forget if it ended up actually being necessary?
There was a problem hiding this comment.
There was a problem hiding this comment.
why are these deleted vs others were renamed?
rebeccamccabe
left a comment
rebeccamccabe
left a comment
There was a problem hiding this comment.
All nontechnical (non-.ipynb and non-.py) changes read and approved. Merging now for journal submission, can follow up with a technical code review later.
No description provided.