fix(e2e): graceful TracingSink shutdown and unique subtest names - #16
Open
syjn99 wants to merge 2 commits into
Open
fix(e2e): graceful TracingSink shutdown and unique subtest names#16syjn99 wants to merge 2 commits into
syjn99 wants to merge 2 commits into
Conversation
Add a done channel to TracingSink so Stop() blocks until initializeSink returns, preventing port 9150 bind conflicts between tests. Wrap checkpoint_sync and beacon_chain_sync evaluator loops in named t.Run blocks so Go's testing framework doesn't deduplicate evaluator subtest names by appending #1 suffixes. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
syjn99
force-pushed
the
fix/e2e-tracing-sink-and-subtest-names
branch
from
March 4, 2026 16:02
c4ba005 to
fd1df44
Compare
…eckpoint sync The AllNodesHaveSameHead evaluator has an internal waitForAllMidEpoch delay that creates a race condition: after waitForMatchingHead confirms heads match, the mid-epoch wait allows the chain to advance while the checkpoint-synced node lags behind, causing head block root mismatches. Replace it with a second waitForMatchingHead call that actively polls until heads match, eliminating the timing gap. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
done chan struct{}field.initializeSinkdefersclose(ts.done)so the goroutine signals completion when it exits.Stop()now callscancel()then blocks on<-ts.done, ensuring the HTTP server has fully released port 9150 before the next test starts.syncEvaluatorsloops intestCheckpointSyncandtestBeaconChainSyncinsidet.Run("checkpoint_sync", ...)andt.Run("beacon_chain_sync", ...)respectively. This prevents Go's testing framework from appending#01suffixes to duplicate evaluator subtest names across the two functions.Test plan
go build ./testing/endtoend/...passes--test_syncand--test_checkpoint_syncenabled and confirm no port-already-in-use errors on the second testcheckpoint_sync/FinishedSyncingandbeacon_chain_sync/FinishedSyncing(no#01suffixes)🤖 Generated with Claude Code