improvement to yazi's image preview downscaling#3797
Closed
caikn wants to merge 9 commits intosxyazi:mainfrom
Closed
improvement to yazi's image preview downscaling#3797caikn wants to merge 9 commits intosxyazi:mainfrom
caikn wants to merge 9 commits intosxyazi:mainfrom
Conversation
The old image crate's DynamicImage::resize() fitted within (w, h) bounds while preserving aspect ratio. fir_resize() was resizing to exact dimensions, stretching images to fill the preview panel.
Owner
|
Closing with #3796 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR resolve?
An improvement to yazi's image preview downscaling so that thumbnails displayed in the terminal preview pane are visibly sharper.
Why it's blurry: The image crate's resize implementation, while functional, uses a simpler convolution approach compared to dedicated image processing libraries (e.g., fast_image_resize). For downscaling large images to small preview sizes, the quality difference is noticeable — especially for fine detail and text in images.
Resolves #3796
Rationale of this PR
Replace both resize call with fast_image_resize, add dependency, map all config filter strings