Add server configuration dialog#234
Merged
Merged
Conversation
This adds a `ClientState` enum used to track the state of the lsp client. The previous `action_run_server` implementation couldn't detect that the server was already running as the `self.server` worker only tracked the state of the `start_server()` coroutine rather than the server itself! By tracking the state of the client directly this implementation now ensures that the previous server is shutdown before starting the next server. This commit also replaces the `stderr_handler` with a regular Python logger allowing for errors and debug info to also be reported. The `StderrReceived` has also been removed in favour of the `OutputWindowHandler` which formats log messages according to their severity and sends it to the associated `OutputWindow`.
alcarney
force-pushed
the
push-nzrzprmokkms
branch
from
3fba1fa to
3b52751
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a dialog to allow the server command to be changed at runtime.
And log more information to the
Serverpanel.