Skip to content

ci: Commit version bumps before tagging and publishing - #28

Merged
krodak merged 1 commit into
swiftwasm:mainfrom
PassiveLogic:fix/tag-driven-release-upstream
Sep 7, 2026
Merged

krodak merged 1 commit into
swiftwasm:mainfrom
PassiveLogic:fix/tag-driven-release-upstream

Conversation

@krodak

@krodak krodak commented Sep 7, 2026 •

Copy link
Copy Markdown
Member

Overview

Commit the version bump before tagging so the repository and published package
have the same version. Start releases manually from main with a stable version
such as 1.5.0, rather than creating a GitHub release first.

1. Versioned source

Update both manifests, build and test, then commit as github-actions[bot].
Push main and its version tag atomically before publishing in the same workflow.

2. Release checks

Reject invalid versions, existing tags, and non-main dispatches. Serialize
releases without cancelling active runs. If npm publishing fails after the push,
publication from the existing tag is a separate recovery operation.

Test Plan

  • npm ci
  • npm test
  • Exercise inline workflow scripts against isolated bare Git repositories: new
    release, existing tag rejection, invalid versions, unchanged version,
    non-main dispatch, and atomic push race.
  • git diff --check

GitHub Actions execution and npm OIDC publishing remain untested.

@krodak krodak self-assigned this Sep 7, 2026
Comment thread .github/workflows/release.yml Outdated
@krodak
krodak force-pushed the fix/tag-driven-release-upstream branch from 2202c72 to b9a9e4a Compare September 7, 2026 10:30
@krodak krodak changed the title fix: Derive the npm release version from its tag ci: Commit version bumps before tagging and publishing Sep 7, 2026

@kateinoigakukun kateinoigakukun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@krodak
krodak force-pushed the fix/tag-driven-release-upstream branch from b9a9e4a to 56bb593 Compare September 7, 2026 10:36
@krodak
krodak merged commit ebce49c into swiftwasm:main Sep 7, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants