Update README.md to add more info and fix typos, fix generator help / output - #275
Merged
MaxDesiatov merged 7 commits intoSep 30, 2026
Conversation
MaxDesiatov
reviewed
Sep 29, 2026
MaxDesiatov
reviewed
Sep 29, 2026
MaxDesiatov
left a comment
MaxDesiatov
left a comment
Contributor
There was a problem hiding this comment.
Overall LGTM, thank you! Only thing I'm unsure about is the QEMU dependency mentioned in the diff. Can we remove it for now so that it isn't a point of contention in this PR specifically? Then it could be addressed separately.
xtremekforever
force-pushed
the
feature/update-readme-and-output
branch
from
September 29, 2026 17:12
e1c6c30 to
4a28caf
Compare
Contributor
Author
The qemu section was removed. I'll open a ticket to look at improving container runtime support separately. |
Contributor
|
@swift-ci test |
MaxDesiatov
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
README.md changes:
Linux Requirements, which is something I ran into when running the swift-sdk-generator on a new Linux install.experimental-prefix from sample commands since now the generator requires Swift 6.0 or higher.Minor code changes:
GeneratorCLI.swift.experimental-prefix from generator help output inSwiftSDKGenerator+Entrypoint.swift