Allow merging of multiple Wasm Swift SDKs in a single bundle - #263
Merged
Merged
Conversation
This enables inclusion of both `wasip1` and `wasip1-threads` within a single artifact bundle distribution.
Contributor
Author
|
@swift-ci test |
MaxDesiatov
commented
Apr 22, 2026
Co-authored-by: Max Desiatov <m_desiatov@apple.com>
Contributor
Author
MaxDesiatov
commented
Apr 22, 2026
Co-authored-by: Max Desiatov <m_desiatov@apple.com>
MaxDesiatov
marked this pull request as ready for review
April 22, 2026 15:35
Contributor
Author
|
@swift-ci test |
Contributor
|
Can this also work to create a bundle for different say Ubuntu target architectures in a Swift SDK, such as having Ubuntu Jammy x86_64 and aarch64 in a single bundle? |
MaxDesiatov
changed the title
Contributor
Author
I haven't tested this specific case, code here is quite Wasm-specific, but infrastructure for that should be present now and I'm open to reviewing PRs that generalize it. |
kateinoigakukun
approved these changes
Apr 23, 2026
kateinoigakukun
left a comment
kateinoigakukun
left a comment
Member
There was a problem hiding this comment.
Still concerning about shipping everything as a single artifactbundle but I don't think we have another option, so I'm ok
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables inclusion of all Wasm Swift SDKs like
wasip1,wasip1-threads, and Emscripten within a single artifact bundle distribution.