Repository navigation
Default trailer to nil in the concrete sendAndFinish - #148
Merged
Merged
Conversation
### Motivation swift-server#136 added a concrete `sendAndFinish(_:buffer:trailer:)` that writes the head, body and end in a single write. We should add a default value to the `trailer` argument so that callers who omit the `trailer` argument can use this optimised implementation instead of the default implementation provided by `HTTPAPIs`. ### Modifications - Default `trailer` to `nil` on the concrete `sendAndFinish`. ### Result Calls without `trailer` get the single-write path.
fabianfett
approved these changes
Oct 16, 2026
Member
|
Love it! |
gjcairo
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
#136 added a concrete
sendAndFinish(_:buffer:trailer:)that writes the head, body and end in a single write.We should add a default value to the
trailerargument so that callers who omit thetrailerargument can use this optimised implementation instead of the default implementation provided byHTTPAPIs.Modifications
Default
trailertonilon the concretesendAndFinish.Result
Callers omitting the
trailerargument can use the optimised implementation.