Repository navigation
Avoid exclusivity conflict in DatagramContext - #146
Merged
Merged
Conversation
FranzBusch
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
DatagramContextcurrently completes the negotiation promise inside its ownmutatingmethods. The promise's callbacks run synchronously and call back intoregister/deregisteron the manager. This results in an exclusivity violation crash for streams opened before SETTINGS. We should fix this.Modifications
Updated
DatagramContextto hand over the promise to the manager handler, which completes it once the mutating access has ended.Result
Streams opened before SETTINGS can register and deregister from the datagram negotiation callbacks without crashing.