Repository navigation
feat(adapter-node): add shebang to build/index.js - #17592
Open
praveen-kumary wants to merge 1 commit into
Open
praveen-kumary wants to merge 1 commit into
praveen-kumary wants to merge 1 commit into
Conversation
Signed-off-by: praveen-kumary <praveenkumar2000y@gmail.com>
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/b390f8533e22d83216b5b214479ef35d12ccc024Open in Note This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed. |
🦋 Changeset detectedLatest commit: b390f85 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #17534.
When running an
@sveltejs/adapter-nodebuild output directly as an executable script or specifyingbuild/index.jsin abinfield, package linters (e.g. publint) report that the file is not executable because it lacks a shebang.Changes
#!/usr/bin/env node\nto${out}/index.jsin@sveltejs/adapter-node.fs.chmodSync(..., 0o755)to mark the file executable where supported.build/index.jsincludes the shebang.