Repository navigation
fix: avoid deleting root route types and metadata cache during sync cleanup - #17591
praveen-kumary wants to merge 1 commit into
Conversation
…leanup (sveltejs#17465) Signed-off-by: praveen-kumary <praveenkumar2000y@gmail.com>
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/2902dcbf41ec7db7ffe8943092f8556332fe757dOpen in Note This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed. |
🦋 Changeset detectedLatest commit: 2902dcb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
|
|
||
| if (fs.existsSync(types_dir)) { | ||
| for (const file of walk(types_dir)) { | ||
| if (file === 'route_meta_data.json') continue; |
There was a problem hiding this comment.
Preserving the metadata cache causes subsequent syncs to leave layout route IDs and params stale when child pages are added or deleted without changing load files.
|
|
||
| if (fs.existsSync(types_dir)) { | ||
| for (const file of walk(types_dir)) { | ||
| if (file === 'route_meta_data.json') continue; |
There was a problem hiding this comment.
With metadata now retained, moving a component-only route directory via files.routes leaves its generated $types.d.ts missing after sync.
Summary
Fixes #17465 and fixes #17464.
During
write_all_types, the obsolete route cleanup pass previously deleted:.svelte-kit/types/src/routes/$types.d.ts: For the root route (route.id === '/'),path.posix.join(routes_dir, route.id)produces'src/routes/'(with a trailing slash), whereaspath.posix.dirname(file)returns'src/routes'. Because'src/routes'was missing fromexpected_directories, the root route types were deleted on every sync pass.route_meta_data.json:walk(types_dir)yieldsroute_meta_data.json, whose dirname is'.'. Because'.'is not a route directory, the metadata cache file was deleted on line 74 immediately beforefs.existsSync(meta_data_file)was called on line 84, defeating the sync cache across runs.Changes
expected_directoriesinpackages/kit/src/core/sync/write_types/index.js.route_meta_data.jsonduring the obsolete-route cleanup loop.$types.d.tsandroute_meta_data.jsonretention across repeated sync runs.