Skip to content

fix: use the UTF-8 byte length when reading inline assets - #17590

Open
clean99 wants to merge 1 commit into
sveltejs:mainfrom
clean99:contrib/sveltekit-inline-asset-content-length
Open

clean99 wants to merge 1 commit into
sveltejs:mainfrom
clean99:contrib/sveltekit-inline-asset-content-length

Conversation

@clean99

@clean99 clean99 commented Oct 31, 2026

Copy link
Copy Markdown

resolves #17589

Returning read(icon) from an endpoint truncates an inlined SVG with a non-ASCII title: the reproduction sends 68 as Content-Length for 73 bytes, cutting off </svg>. Encode the decoded data URL with the existing UTF-8 encoder and measure those bytes, as the base64 branch already does.

Regression tests cover ASCII, accented text, CJK, a surrogate pair, unescaped data and base64. Format, lint, check, type generation and all Kit unit tests passed (1,131 passed, 1 skipped). A production-build HTTP reproduction fails with only the source reverted and passes with the fix. The full integration matrix was not run.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@pkg-svelte-dev

Copy link
Copy Markdown

Install the latest version of @sveltejs/kit from 72d3be6:

pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/72d3be6a3638ebf95c1bd7355a6054173f19a6be

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/kit/pr/17590

Note

This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed.

@changeset-bot

changeset-bot Bot commented Oct 31, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 72d3be6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Returning read() from an endpoint truncates an inline SVG with a non-ASCII title

1 participant