Repository navigation
fix: set enter navigation source to null when SSR is disabled - #17588
Draft
svelte-triage-bot[bot] wants to merge 1 commit into
Draft
svelte-triage-bot[bot] wants to merge 1 commit into
svelte-triage-bot[bot] wants to merge 1 commit into
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/3a5a11186f685fd4557ab3cfc465cf606ddb60abOpen in Note This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed. |
🦋 Changeset detectedLatest commit: 3a5a111 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17586
On a direct load with
ssr = false,navigateconstructs the initialenternavigation beforecurrentrepresents a page. The shared constructor nevertheless creates a source target from that empty state, exposingfrom.url === nulldespiteNavigationTarget.urlbeing a URL. Consequently, expressions such asnavigation.from?.url.pathnamethrow. Hydration already suppliesfrom: null.#13593 intentionally moved client-only startup onto the navigation path so that it emits one
entercallback rather than separateenterandgotocallbacks. That mechanism remains necessary; its constructor simply retained the old assumption that every navigation has an outgoing page. #17577 corrected the destination of the separate hydrating startup path, but did not affect this source target.Construct
from: nullforenternavigations in the shared constructor, rather than fabricating an initial target or overwriting it later. This preserves startup callback timing and redirect handling, and leaves non-enter targets unchanged, including scroll information from #15248 and shallow-navigation handling from #16449.The existing client-only fixture now covers direct entry, reload, the initial destination, and a subsequent
gotowith a real source target. The hydrated dynamic-route fixture also checks its null source, protecting the parallel startup path.