Repository navigation
fix: set navigation.from to null on start without SSR - #17587
Open
stickerdaniel wants to merge 1 commit into
Open
stickerdaniel wants to merge 1 commit into
stickerdaniel wants to merge 1 commit into
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/b35dcb0f606cde57159a4bb08cc9a25784cb5cbeOpen in Note This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed. |
🦋 Changeset detectedLatest commit: b35dcb0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #17586
Problem
When a page with
ssr = falseis loaded directly,afterNavigategets anenternavigation withfrom: { route: { id: null }, url: null, … }instead ofnull, sonavigation.from?.url.pathnamethrows.create_navigation()buildsfromfromcurrent, which is still empty before the first page loads. The hydrating start path already passesfrom: null.Solution
create_navigation()setsfromtonullforenternavigations, so both start paths match.Verification
A new test in the
SPA mode / no SSRgroup expectsfrom: nullon a client-rendered page. It fails without the change. Navigation, snapshot and SPA tests inbasicspass in dev, build, server-side route resolution and async mode, as do unit tests, lint andpnpm check. With a packed build of this branch, the repro from the issue showsfrom: null.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits
Implemented with Claude Opus 5.5 (xhigh) and reviewed with GPT-6 (Extra High) in Claude Code via T3 Code.