Skip to content

fix: set navigation.from to null on start without SSR - #17587

Open
stickerdaniel wants to merge 1 commit into
sveltejs:mainfrom
stickerdaniel:fix/enter-navigation-from
Open

stickerdaniel wants to merge 1 commit into
sveltejs:mainfrom
stickerdaniel:fix/enter-navigation-from

Conversation

@stickerdaniel

Copy link
Copy Markdown

closes #17586

Problem

When a page with ssr = false is loaded directly, afterNavigate gets an enter navigation with from: { route: { id: null }, url: null, … } instead of null, so navigation.from?.url.pathname throws. create_navigation() builds from from current, which is still empty before the first page loads. The hydrating start path already passes from: null.

Solution

create_navigation() sets from to null for enter navigations, so both start paths match.

Verification

A new test in the SPA mode / no SSR group expects from: null on a client-rendered page. It fails without the change. Navigation, snapshot and SPA tests in basics pass in dev, build, server-side route resolution and async mode, as do unit tests, lint and pnpm check. With a packed build of this branch, the repro from the issue shows from: null.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Implemented with Claude Opus 5.5 (xhigh) and reviewed with GPT-6 (Extra High) in Claude Code via T3 Code.

@pkg-svelte-dev

Copy link
Copy Markdown

Install the latest version of @sveltejs/kit from b35dcb0:

pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/b35dcb0f606cde57159a4bb08cc9a25784cb5cbe

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/kit/pr/17587

Note

This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed.

@changeset-bot

changeset-bot Bot commented Oct 31, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: b35dcb0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] afterNavigate gets a from with url: null on start when SSR is disabled

1 participant