Repository navigation
fix: serve prerendered pages when paths.base is set on Vercel - #17525
Draft
elliott-with-the-longest-name-on-github wants to merge 1 commit into
Draft
elliott-with-the-longest-name-on-github wants to merge 1 commit into
elliott-with-the-longest-name-on-github wants to merge 1 commit into
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/6d25e5a62176104ddc31329e9e9f0af8eec5ed2cOpen in |
🦋 Changeset detectedLatest commit: 6d25e5a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
paths.baseset, prerendered pages 404 on Vercel. Only the.htmlURL, e.g./base/blog/post.html, is served.Basically,
builder.prerendered.pagesrecords each page's file relative tobase(blog/post.html), but adapter-vercel writes the files to.vercel/output/static${base}. So the file is really atbase/blog/post.html. The adapter used the base-relative path as theoverrideskey, andoverrideskeys are relative tostatic. That means they never matched a file, and the pages were never renamed to their clean URLs.This fixes it by adding the base to the keys. adapter-static's Vercel output doesn't have this problem, because it writes prerendered pages directly into
.vercel/output/static.The new
paths-basetest app only runs build tests, which check that everyoverrideskey refers to a file that exists. Both fail without the fix. I also deployed it to confirm that/base/and/base/prerendered/aare served and that/base/prerendered/a/redirects.