Repository navigation
Fix: Licensing SDK deletes stored licence key on temporary API errors - #25
Merged
mzakash merged 7 commits intoSep 16, 2026
Conversation
Patch release for the licensing SDK fix that keeps the stored license key on temporary API errors instead of clearing it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
mzakash
deleted the
akash/sur-5796-licensing-sdk-deletes-stored-licence-key-on-temporary-api
branch
September 16, 2026 12:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Settings::get_activation()previously wiped the stored license key/activation on any API error (including transient network failures or 5xx responses), forcing merchants to re-enter a valid license key after a temporary outage.not_found(404) response — meaning the activation genuinely no longer exists — clears theactivation_idand prompts re-activation.Why
Temporary API/network errors were being treated the same as a real deactivation, silently logging merchants out of their license after any blip in connectivity to the licensing server.
Test plan
not_foundactivation response → confirm activation id is cleared and re-activation is prompted.