fix(postgrest): use params.set() for limit/offset/range — setter semantics - #1618
Open
abhi-0203 wants to merge 1 commit into
Open
fix(postgrest): use params.set() for limit/offset/range — setter semantics#1618abhi-0203 wants to merge 1 commit into
abhi-0203 wants to merge 1 commit into
Conversation
…fset/range Fixes duplicate query params when limit()/offset()/range() called multiple times. Before: .limit(10).limit(20) sent limit=10&limit=20 (httpx uses last, client sees first) After: .limit(10).limit(20) sends limit=20 (consistent with order() behavior) Closes supabase#1617
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
limit(),offset(), andrange()usedparams.add()which allows duplicate keys, so calling them twice sends duplicate query params (limit=10&limit=20). httpx uses the last value server-side, but the client sees the first value when reading back — an inconsistency trap.The fix changes all three methods to use
params.set(), matching howorder()already works.Changes
src/postgrest/src/postgrest/base_request_builder.py:limit():params.add()→params.set()offset():params.add()→params.set()range():params.add()→params.set()(both offset and limit)Verification
Closes #1617