fix(postgrest): handle empty HEAD error responses - #1587
Open
SohailKhan0525 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix.
What is the current behavior?
A HEAD request that returns an HTTP error with an empty response body causes the client to attempt JSON parsing of the empty body, resulting in a Pydantic
ValidationErrorinstead of the expectedAPIError.What is the new behavior?
Empty error response bodies are handled before JSON parsing, and the existing default
APIErroris raised with the HTTP status code.A regression test verifies that
model_validate_jsonis not called for an empty HEAD error response.Additional context
This addresses supabase/supabase#1584.
Tests: