fix: filter relationship SQL by nspname, not regnamespace::text - #1149
Open
hsusul wants to merge 1 commit into
Open
fix: filter relationship SQL by nspname, not regnamespace::text#1149hsusul wants to merge 1 commit into
hsusul wants to merge 1 commit into
Conversation
Quoted schema names (dotted or mixed-case) made schemaFilter miss and left FK column lists null for typegen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
connamespace::regnamespace::textmissschemaFilter, leaving FKcolumns/referenced_columnsnull for typegen.pg_namespace.nspname(and oid subquery in views key deps); drop the redundant lateralregnamespacefilter now covered by the outerns1.nspnamepredicate."odd.schema"and"MySchema".Test plan
npx vitest run test/index.test.ts -t "relationships list includes columns"