Skip to content

fix: quote check constraint names when dropping via column update #1141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hsusul wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: quote check constraint names when dropping via column update #1141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/PostgresMetaColumns.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,7 @@ BEGIN
IF v_conname IS NOT NULL THEN
EXECUTE format('ALTER TABLE ${ident(old!.schema)}.${ident(
old!.table
)} DROP CONSTRAINT %s', v_conname);
)} DROP CONSTRAINT %I', v_conname);
END IF;

${
Expand Down
21 changes: 21 additions & 0 deletions test/lib/columns.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -981,6 +981,27 @@ test('dropping column checks', async () => {
await pgMeta.query(`drop table t`)
})

test('dropping hyphenated column check constraints', async () => {
await pgMeta.query(`
create table public.t (c int8);
alter table public.t add constraint "t-c-check" check (c <> 0);
`)

let res = await pgMeta.columns.retrieve({
schema: 'public',
table: 't',
name: 'c',
})
expect(res.error).toBeNull()
expect(res.data?.check).toBeTruthy()

res = await pgMeta.columns.update(res.data!.id, { check: null })
expect(res.error).toBeNull()
expect(res.data?.check).toBeNull()

await pgMeta.query(`drop table public.t`)
})

test('column with fully-qualified type', async () => {
await pgMeta.query(`create table public.t(); create schema s; create type s.my_type as enum ();`)

Expand Down