Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/PostgresMetaForeignTables.ts
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ const generateEnrichedForeignTablesSql = ({
limit?: number
offset?: number
}) => `
with foreign_tables as (${FOREIGN_TABLES_SQL({ schemaFilter, tableIdentifierFilter, limit, offset })})
with foreign_tables as (${FOREIGN_TABLES_SQL({ schemaFilter, tableIdentifierFilter, idsFilter, limit, offset })})
${includeColumns ? `, columns as (${COLUMNS_SQL({ schemaFilter, tableIdentifierFilter, tableIdFilter: idsFilter })})` : ''}
select
*
Expand Down
29 changes: 29 additions & 0 deletions test/lib/foreign-tables.ts
Original file line number Diff line number Diff line change
Expand Up @@ -173,3 +173,32 @@ test('retrieve', async () => {
}
`)
})

test('retrieve by id returns the matching foreign table among several', async () => {
await pgMeta.query(`
create foreign table public.foreign_table_2 (
id int8 not null
) server foreign_server options (schema_name 'public', table_name 'users');
`)

try {
const listed = await pgMeta.foreignTables.list({ includeColumns: false })
const first = listed.data!.find(({ name }) => name === 'foreign_table')
const second = listed.data!.find(({ name }) => name === 'foreign_table_2')
expect(first).toBeTruthy()
expect(second).toBeTruthy()
expect(first!.id).not.toBe(second!.id)

const retrievedSecond = await pgMeta.foreignTables.retrieve({ id: second!.id })
expect(retrievedSecond.error).toBeNull()
expect(retrievedSecond.data!.name).toBe('foreign_table_2')
expect(retrievedSecond.data!.id).toBe(second!.id)

const retrievedFirst = await pgMeta.foreignTables.retrieve({ id: first!.id })
expect(retrievedFirst.error).toBeNull()
expect(retrievedFirst.data!.name).toBe('foreign_table')
expect(retrievedFirst.data!.id).toBe(first!.id)
} finally {
await pgMeta.query(`drop foreign table if exists public.foreign_table_2`)
}
})