Conversation
xlgmokha
changed the title
This comment has been minimized.
This comment has been minimized.
xlgmokha
marked this pull request as ready for review
August 26, 2026 23:17
xlgmokha
force-pushed
the
auth-1547
branch
3 times, most recently
from
September 1, 2026 17:01
c2f4f97 to
416068a
Compare
xlgmokha
changed the title
Bump to github.com/crewjam/saml@v0.5.1 to support RSA-SHA256 crewjam/saml@v0.4.14...v0.5.1
hf
reviewed
Sep 2, 2026
| }) | ||
|
|
||
| provider.AuthnNameIDFormat = saml.PersistentNameIDFormat | ||
| provider.SignatureMethod = dsig.RSASHA256SignatureMethod |
Contributor
There was a problem hiding this comment.
How sure are you this isn't going to break existing customers?
hf
approved these changes
Sep 2, 2026
hf
left a comment
hf
left a comment
Contributor
There was a problem hiding this comment.
Likely won't be an issue but needs careful rollout.
Contributor
Author
|
I will try to see if I can gate this change so that it is scoped to specific instances. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix. Update crewjam/saml to support rsa-sha256 signatures and use it.
What is the current behavior?
Generates a SAML Authnrequest with a rsa-sha1 signature.
What is the new behavior?
Generates a SAML Authnrequest with a rsa-sha256 signature.
Additional context