fix(external): use email_address_not_provided instead of 500 when provider omits email (fixes #2583) - #2713
Open
deepshekhardas wants to merge 1 commit into
Conversation
…vider omits email (fixes supabase#2583)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(external): use email_address_not_provided instead of 500 when provider omits email (fixes #2583)
When an external OAuth provider returns no email and the provider is not
email-optional, the callback returns a generic 500
(
unexpected_failure), mis-classifying a non-server fault and leavingclients no stable code to branch on.
Use the existing but unused
email_address_not_providederror code with422, matching how nearby external-identity conditions are reported. The
OAuth redirect keeps
error=server_error(422 is not inoauthErrorMap), so existing clients are unaffected while new clientsgain a stable code.